Cleanup of unnecessary code

API/Program.cs

@@ -1,4 +1,3 @@
-using System.Text.Json.Serialization;
 using OSMDatastructure;
 using OSMDatastructure.Graph;
 using Pathfinding;

OSMDatastructure/Graph/OsmNode.cs

@@ -12,15 +12,15 @@ public class OsmNode
     public OsmNode(ulong nodeId, float lat, float lon)
     {
         this.nodeId = nodeId;
-        this.edges = new();
+        edges = new();
-        this.coordinates = new Coordinates(lat, lon);
+        coordinates = new Coordinates(lat, lon);
     }
 
     [JsonConstructor]
     public OsmNode(ulong nodeId, Coordinates coordinates)
     {
         this.nodeId = nodeId;
-        this.edges = new();
+        edges = new();
         this.coordinates = coordinates;
     }
     
@@ -29,7 +29,8 @@ public class OsmNode
         HashSet<OsmEdge> e = edges.Where(edge => edge.neighborId == n.nodeId).ToHashSet();
         if (e.Count > 0)
             return e.First();
-        else return null;
+        
+        return null;
     }
 
     public override bool Equals(object? obj)

OSMDatastructure/Region.cs

@@ -47,16 +47,12 @@ public class Region
 
     public OsmNode? GetNode(ulong id)
     {
-        if (ContainsNode(id))
+        return ContainsNode(id) ? nodes.First(node => node.nodeId == id) : null;
-            return nodes.First(node => node.nodeId == id);
-        else return null;
     }
 
     public OsmNode? GetNode(Coordinates coordinates)
     {
-        if (ContainsNode(coordinates))
+        return ContainsNode(coordinates) ? nodes.First(node => node.coordinates.Equals(coordinates)) : null;
-            return nodes.First(node => node.coordinates.Equals(coordinates));
-        else return null;
     }
 
 }

OSMDatastructure/TagManager.cs

@@ -1,5 +1,4 @@
 using System.Text.Json.Serialization;
-using OSMDatastructure.Graph;
 
 namespace OSMDatastructure;
 

Pathfinding/PathNode.cs

@@ -1,4 +1,3 @@
-using System.Diagnostics.Tracing;
 using System.Text.Json.Serialization;
 using OSMDatastructure;
 using OSMDatastructure.Graph;

Pathfinding/Pathfinder.cs

@@ -50,7 +50,7 @@ public class Pathfinder
             if (currentNode.Equals(goalNode))
             {
                 Console.WriteLine("Path found.");
-                this.pathResult = GetPath(goalNode, DateTime.Now - startCalc);
+                pathResult = GetPath(goalNode, DateTime.Now - startCalc);
                 return this;
             }
 

Pathfinding/RegionManager.cs

@@ -23,29 +23,26 @@ namespace Pathfinding
         {
             if(_regions.TryGetValue(id, out Region? value))
                 return value;
-            else
+            
-            {
+            Region? loadedRegion = RegionFromId(id);
-                Region? loadedRegion = RegionFromId(id);
+            if(loadedRegion is not null)
-                if(loadedRegion is not null)
+                _regions.Add(loadedRegion!.regionHash, value: loadedRegion);
-                    _regions.Add(loadedRegion!.regionHash, value: loadedRegion);
+            return loadedRegion;
-                return loadedRegion;
-            }
         }
 
         public Region[] GetAllRegions()
         {
-            return this._regions.Values.ToArray();
+            return _regions.Values.ToArray();
         }
 
         private Region? RegionFromFile(string filePath)
         {
-            Region? retRegion = null;
+            if (!File.Exists(filePath)) 
-            if (File.Exists(filePath))
+                return null;
-            {
+            
-                FileStream regionFile = new FileStream(filePath, FileMode.Open);
+            FileStream regionFile = new (filePath, FileMode.Open);
-                retRegion = JsonSerializer.Deserialize<Region>(regionFile, Region.serializerOptions)!;
+            Region retRegion = JsonSerializer.Deserialize<Region>(regionFile, Region.serializerOptions)!;
-                regionFile.Dispose();
+            regionFile.Dispose();
-            }
             return retRegion;
         }
 

RenderPath/Renderer.cs

@@ -1,7 +1,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Drawing;
 using System.Drawing.Imaging;
-using System.Text.Json;
 using OSMDatastructure.Graph;
 using Pathfinding;
 

Server/ConsoleWriter.cs

@@ -1,4 +1,3 @@
-using System.Globalization;
 using System.Text;
 
 namespace Server;