diff --git a/Tranga-CLI/Tranga_Cli.cs b/Tranga-CLI/Tranga_Cli.cs index a57cd82..1aea113 100644 --- a/Tranga-CLI/Tranga_Cli.cs +++ b/Tranga-CLI/Tranga_Cli.cs @@ -130,6 +130,7 @@ public static class Tranga_Cli selection = Console.ReadKey().Key; taskManager.Shutdown(selection == ConsoleKey.Y); }else + // ReSharper disable once RedundantArgumentDefaultValue Better readability taskManager.Shutdown(false); } @@ -160,7 +161,7 @@ public static class Tranga_Cli int tIndex = 0; Console.WriteLine($"Tasks (Running/Total): {taskRunningCount}/{taskCount}"); foreach(TrangaTask trangaTask in tasks) - Console.WriteLine($"{tIndex++:000}: {trangaTask.ToString()}"); + Console.WriteLine($"{tIndex++:000}: {trangaTask}"); } private static void ExecuteTaskNow(TaskManager taskManager) diff --git a/Tranga/Connector.cs b/Tranga/Connector.cs index 647698c..31fd6a3 100644 --- a/Tranga/Connector.cs +++ b/Tranga/Connector.cs @@ -98,6 +98,7 @@ public abstract class Connector /// List of URLs to download Images from /// Full path to save archive to (without file ending .cbz) /// DownloadClient of the connector + /// Path of the generate Chapter ComicInfo.xml, if it was generated protected static void DownloadChapterImages(string[] imageUrls, string saveArchiveFilePath, DownloadClient downloadClient, string? comicInfoPath = null) { //Check if Publication Directory already exists diff --git a/Tranga/Publication.cs b/Tranga/Publication.cs index 029fb75..2d6c668 100644 --- a/Tranga/Publication.cs +++ b/Tranga/Publication.cs @@ -8,7 +8,9 @@ namespace Tranga; public readonly struct Publication { public string sortName { get; } + // ReSharper disable UnusedAutoPropertyAccessor.Global we need it, trust [JsonIgnore]public string[,] altTitles { get; } + // ReSharper disable trice MemberCanBePrivate.Global, trust public string? description { get; } public string[] tags { get; } public string? posterUrl { get; } @@ -47,6 +49,7 @@ public readonly struct Publication //Only for series.json private struct SeriesInfo { + // ReSharper disable once UnusedAutoPropertyAccessor.Local we need it, trust [JsonRequired]public Metadata metadata { get; } public SeriesInfo(Metadata metadata) => this.metadata = metadata; } @@ -54,6 +57,7 @@ public readonly struct Publication //Only for series.json what an abomination, why are all the fields not-null???? private struct Metadata { + // ReSharper disable UnusedAutoPropertyAccessor.Local we need it, trust [JsonRequired] public string type { get; } [JsonRequired] public string publisher { get; } // ReSharper disable twice IdentifierTypo diff --git a/Tranga/TrangaTask.cs b/Tranga/TrangaTask.cs index 4e6db65..2951233 100644 --- a/Tranga/TrangaTask.cs +++ b/Tranga/TrangaTask.cs @@ -7,6 +7,8 @@ namespace Tranga; /// public class TrangaTask { + // ReSharper disable once CommentTypo ...tell me why! + // ReSharper disable once MemberCanBePrivate.Global I want it thaaat way public TimeSpan reoccurrence { get; } public DateTime lastExecuted { get; set; } public string connectorName { get; }