diff --git a/API/Schema/MangaContext/Chapter.cs b/API/Schema/MangaContext/Chapter.cs index 61663a1..ba59338 100644 --- a/API/Schema/MangaContext/Chapter.cs +++ b/API/Schema/MangaContext/Chapter.cs @@ -71,7 +71,11 @@ public class Chapter : Identifiable, IComparable /// Checks the filesystem if an archive at the ArchiveFilePath exists /// /// True if archive exists on disk - public bool CheckDownloaded() => File.Exists(FullArchiveFilePath); + public bool CheckDownloaded() + { + //TODO Log here + return File.Exists(FullArchiveFilePath); + } /// Placeholders: /// %M Obj Name diff --git a/API/Schema/MangaContext/MetadataFetchers/MetadataEntry.cs b/API/Schema/MangaContext/MetadataFetchers/MetadataEntry.cs index ca0126d..d6390fa 100644 --- a/API/Schema/MangaContext/MetadataFetchers/MetadataEntry.cs +++ b/API/Schema/MangaContext/MetadataFetchers/MetadataEntry.cs @@ -32,4 +32,6 @@ public class MetadataEntry this.Identifier = identifier; this.MetadataFetcherName = metadataFetcherName; } + + public override string ToString() => $"{GetType().FullName} {MangaId} {MetadataFetcherName}"; } \ No newline at end of file diff --git a/API/Schema/MangaContext/MetadataFetchers/MyAnimeList.cs b/API/Schema/MangaContext/MetadataFetchers/MyAnimeList.cs index f4fd305..49aad52 100644 --- a/API/Schema/MangaContext/MetadataFetchers/MyAnimeList.cs +++ b/API/Schema/MangaContext/MetadataFetchers/MyAnimeList.cs @@ -48,12 +48,22 @@ public class MyAnimeList : MetadataFetcher /// public override async Task UpdateMetadata(MetadataEntry metadataEntry, MangaContext dbContext, CancellationToken token) { - if (await dbContext.Mangas.FirstOrDefaultAsync(m => m.Key == metadataEntry.MangaId, token) is not { } dbManga) - throw new DbUpdateException("Manga not found"); - + Manga? dbManga = metadataEntry.Manga; //Might be null! + if (dbManga is null) + { + if (await dbContext.Mangas.FirstOrDefaultAsync(m => m.Key == metadataEntry.MangaId, token) is not + { } update) + throw new DbUpdateException("Manga not found"); + dbManga = update; + } + + // Load all collections (tags, links, authors)... foreach (CollectionEntry collectionEntry in dbContext.Entry(dbManga).Collections) - await collectionEntry.LoadAsync(token); - await dbContext.Entry(dbManga).Navigation(nameof(Manga.Library)).LoadAsync(token); + { + if(!collectionEntry.IsLoaded) + await collectionEntry.LoadAsync(token); + } + await dbContext.Entry(dbManga).Reference(m => m.Library).LoadAsync(token); MangaFull resultData; try diff --git a/API/Tranga.cs b/API/Tranga.cs index 71e63c2..2391fc3 100644 --- a/API/Tranga.cs +++ b/API/Tranga.cs @@ -207,28 +207,4 @@ public static class Tranga return true; } - - internal static bool AddChapterToContext((Chapter, MangaConnectorId) addChapter, MangaContext context, [NotNullWhen(true)] out Chapter? chapter, CancellationToken token) => - AddChapterToContext(addChapter.Item1, addChapter.Item2, context, out chapter, token); - - internal static bool AddChapterToContext(Chapter addChapter, MangaConnectorId addChId, MangaContext context, [NotNullWhen(true)] out Chapter? chapter, CancellationToken token) - { - chapter = context.Chapters.Where(ch => ch.Key == addChapter.Key) - .Include(ch => ch.ParentManga) - .Include(ch => ch.MangaConnectorIds) - .FirstOrDefault(); - if (chapter is not null) - { - chapter.MangaConnectorIds = chapter.MangaConnectorIds.UnionBy(addChapter.MangaConnectorIds, id => id.Key).ToList(); - } - else - { - context.Chapters.Add(addChapter); - chapter = addChapter; - } - - if (context.Sync(token).Result is { success: false }) - return false; - return true; - } } \ No newline at end of file diff --git a/API/Workers/BaseWorker.cs b/API/Workers/BaseWorker.cs index bf2097a..ef7e01c 100644 --- a/API/Workers/BaseWorker.cs +++ b/API/Workers/BaseWorker.cs @@ -26,7 +26,8 @@ public abstract class BaseWorker : Identifiable public IEnumerable MissingDependencies => DependsOn.Where(d => d.State < WorkerExecutionState.Completed); public bool AllDependenciesFulfilled => DependsOn.All(d => d.State >= WorkerExecutionState.Completed); internal WorkerExecutionState State { get; private set; } - protected CancellationTokenSource CancellationTokenSource = new (); + private CancellationTokenSource _cancellationTokenSource = new (); + protected CancellationToken CancellationToken => _cancellationTokenSource.Token; protected ILog Log { get; init; } /// @@ -36,7 +37,7 @@ public abstract class BaseWorker : Identifiable { Log.Debug($"Cancelled {this}"); this.State = WorkerExecutionState.Cancelled; - CancellationTokenSource.Cancel(); + _cancellationTokenSource.Cancel(); } /// @@ -46,7 +47,7 @@ public abstract class BaseWorker : Identifiable { Log.Debug($"Failed {this}"); this.State = WorkerExecutionState.Failed; - CancellationTokenSource.Cancel(); + _cancellationTokenSource.Cancel(); } public BaseWorker(IEnumerable? dependsOn = null) @@ -75,7 +76,7 @@ public abstract class BaseWorker : Identifiable { // Start the worker Log.Debug($"Checking {this}"); - this.CancellationTokenSource = new(TimeSpan.FromMinutes(10)); + this._cancellationTokenSource = new(TimeSpan.FromMinutes(10)); this.State = WorkerExecutionState.Waiting; // Wait for dependencies, start them if necessary @@ -111,7 +112,7 @@ public abstract class BaseWorker : Identifiable private BaseWorker[] WaitForDependencies() { Log.Info($"Waiting for {MissingDependencies.Count()} Dependencies {this}:\n\t{string.Join("\n\t", MissingDependencies.Select(d => d.ToString()))}"); - while (CancellationTokenSource.IsCancellationRequested == false && MissingDependencies.Any()) + while (_cancellationTokenSource.IsCancellationRequested == false && MissingDependencies.Any()) { Thread.Sleep(Tranga.Settings.WorkCycleTimeoutMs); } diff --git a/API/Workers/MangaDownloadWorkers/DownloadChapterFromMangaconnectorWorker.cs b/API/Workers/MangaDownloadWorkers/DownloadChapterFromMangaconnectorWorker.cs index e0abf5c..09460a9 100644 --- a/API/Workers/MangaDownloadWorkers/DownloadChapterFromMangaconnectorWorker.cs +++ b/API/Workers/MangaDownloadWorkers/DownloadChapterFromMangaconnectorWorker.cs @@ -13,28 +13,41 @@ using static System.IO.UnixFileMode; namespace API.Workers; +/// +/// Downloads single chapter for Manga from Mangaconnector +/// +/// +/// public class DownloadChapterFromMangaconnectorWorker(MangaConnectorId chId, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn) { internal readonly string MangaConnectorIdId = chId.Key; protected override async Task DoWorkInternal() { - if(await DbContext.MangaConnectorToChapter.FirstOrDefaultAsync(c => c.Key == MangaConnectorIdId, CancellationTokenSource.Token) is not { } mangaConnectorId) + Log.Debug($"Downloading chapter for MangaConnectorId {MangaConnectorIdId}..."); + // Getting MangaConnector info + if (await DbContext.MangaConnectorToChapter + .Include(id => id.Obj) + .ThenInclude(c => c.ParentManga) + .ThenInclude(m => m.Library) + .FirstOrDefaultAsync(c => c.Key == MangaConnectorIdId, CancellationToken) is not { } mangaConnectorId) + { + Log.Error("Could not get MangaConnectorId."); return []; //TODO Exception? + } if (!Tranga.TryGetMangaConnector(mangaConnectorId.MangaConnectorName, out MangaConnector? mangaConnector)) + { + Log.Error("Could not get MangaConnector."); return []; //TODO Exception? + } + Log.Debug($"Downloading chapter for MangaConnectorId {mangaConnectorId}..."); - await DbContext.Entry(mangaConnectorId).Navigation(nameof(MangaConnectorId.Obj)).LoadAsync(CancellationTokenSource.Token); Chapter chapter = mangaConnectorId.Obj; if (chapter.Downloaded) { Log.Info("Chapter was already downloaded."); return []; } - - await DbContext.Entry(chapter).Navigation(nameof(Chapter.ParentManga)).LoadAsync(CancellationTokenSource.Token); - await DbContext.Entry(chapter.ParentManga).Navigation(nameof(Manga.Library)).LoadAsync(CancellationTokenSource.Token); - if (chapter.ParentManga.LibraryId is null) { Log.Info($"Library is not set for {chapter.ParentManga} {chapter}"); @@ -97,9 +110,8 @@ public class DownloadChapterFromMangaconnectorWorker(MangaConnectorId c Log.Debug($"Creating ComicInfo.xml {chapter}"); foreach (CollectionEntry collectionEntry in DbContext.Entry(chapter.ParentManga).Collections) - await collectionEntry.LoadAsync(CancellationTokenSource.Token); - await DbContext.Entry(chapter.ParentManga).Navigation(nameof(Manga.Library)).LoadAsync(CancellationTokenSource.Token); - await File.WriteAllTextAsync(Path.Join(tempFolder, "ComicInfo.xml"), chapter.GetComicInfoXmlString(), CancellationTokenSource.Token); + await collectionEntry.LoadAsync(CancellationToken); + await File.WriteAllTextAsync(Path.Join(tempFolder, "ComicInfo.xml"), chapter.GetComicInfoXmlString(), CancellationToken); Log.Debug($"Packaging images to archive {chapter}"); //ZIP-it and ship-it @@ -107,9 +119,12 @@ public class DownloadChapterFromMangaconnectorWorker(MangaConnectorId c if (RuntimeInformation.IsOSPlatform(OSPlatform.Linux)) File.SetUnixFileMode(saveArchiveFilePath, UserRead | UserWrite | UserExecute | GroupRead | GroupWrite | GroupExecute | OtherRead | OtherExecute); Directory.Delete(tempFolder, true); //Cleanup + + DbContext.Entry(chapter).Property(c => c.Downloaded).CurrentValue = true; + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); - chapter.Downloaded = true; - await DbContext.Sync(CancellationTokenSource.Token); + Log.Debug($"Downloaded chapter {chapter}."); return []; } @@ -164,7 +179,7 @@ public class DownloadChapterFromMangaconnectorWorker(MangaConnectorId c } //TODO MangaConnector Selection - await DbContext.Entry(manga).Collection(m => m.MangaConnectorIds).LoadAsync(CancellationTokenSource.Token); + await DbContext.Entry(manga).Collection(m => m.MangaConnectorIds).LoadAsync(CancellationToken); MangaConnectorId mangaConnectorId = manga.MangaConnectorIds.First(); if (!Tranga.TryGetMangaConnector(mangaConnectorId.MangaConnectorName, out MangaConnector? mangaConnector)) { @@ -173,7 +188,7 @@ public class DownloadChapterFromMangaconnectorWorker(MangaConnectorId c } Log.Info($"Copying cover to {publicationFolder}"); - await DbContext.Entry(mangaConnectorId).Navigation(nameof(MangaConnectorId.Obj)).LoadAsync(CancellationTokenSource.Token); + await DbContext.Entry(mangaConnectorId).Navigation(nameof(MangaConnectorId.Obj)).LoadAsync(CancellationToken); string? fileInCache = manga.CoverFileNameInCache ?? mangaConnector.SaveCoverImageToCache(mangaConnectorId); if (fileInCache is null) { diff --git a/API/Workers/MangaDownloadWorkers/DownloadCoverFromMangaconnectorWorker.cs b/API/Workers/MangaDownloadWorkers/DownloadCoverFromMangaconnectorWorker.cs index c6581b3..82e12c3 100644 --- a/API/Workers/MangaDownloadWorkers/DownloadCoverFromMangaconnectorWorker.cs +++ b/API/Workers/MangaDownloadWorkers/DownloadCoverFromMangaconnectorWorker.cs @@ -4,23 +4,42 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Downloads the cover for Manga from Mangaconnector +/// public class DownloadCoverFromMangaconnectorWorker(MangaConnectorId mcId, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn) { internal readonly string MangaConnectorIdId = mcId.Key; protected override async Task DoWorkInternal() { - if (await DbContext.MangaConnectorToManga.FirstOrDefaultAsync(c => c.Key == MangaConnectorIdId) is not { } mangaConnectorId) + Log.Debug($"Getting Cover for MangaConnectorId {MangaConnectorIdId}..."); + // Getting MangaConnector info + if (await DbContext.MangaConnectorToManga + .Include(id => id.Obj) + .FirstOrDefaultAsync(c => c.Key == MangaConnectorIdId, CancellationToken) is not { } mangaConnectorId) + { + Log.Error("Could not get MangaConnectorId."); return []; //TODO Exception? + } if (!Tranga.TryGetMangaConnector(mangaConnectorId.MangaConnectorName, out MangaConnector? mangaConnector)) + { + Log.Error("Could not get MangaConnector."); return []; //TODO Exception? - - await DbContext.Entry(mangaConnectorId).Navigation(nameof(MangaConnectorId.Obj)).LoadAsync(CancellationTokenSource.Token); - Manga manga = mangaConnectorId.Obj; - - manga.CoverFileNameInCache = mangaConnector.SaveCoverImageToCache(mangaConnectorId); + } + Log.Debug($"Getting Cover for MangaConnectorId {mangaConnectorId}..."); - await DbContext.Sync(CancellationTokenSource.Token); + string? coverFileName = mangaConnector.SaveCoverImageToCache(mangaConnectorId); + if (coverFileName is null) + { + Log.Error($"Could not get Cover for MangaConnectorId {mangaConnectorId}."); + return []; + } + DbContext.Entry(mangaConnectorId.Obj).Property(m => m.CoverFileNameInCache).CurrentValue = coverFileName; + + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); + return []; } diff --git a/API/Workers/MangaDownloadWorkers/RetrieveMangaChaptersFromMangaconnectorWorker.cs b/API/Workers/MangaDownloadWorkers/RetrieveMangaChaptersFromMangaconnectorWorker.cs index 64434df..b428661 100644 --- a/API/Workers/MangaDownloadWorkers/RetrieveMangaChaptersFromMangaconnectorWorker.cs +++ b/API/Workers/MangaDownloadWorkers/RetrieveMangaChaptersFromMangaconnectorWorker.cs @@ -4,35 +4,51 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Retrieves the metadata of available chapters on the Mangaconnector +/// +/// +/// +/// public class RetrieveMangaChaptersFromMangaconnectorWorker(MangaConnectorId mcId, string language, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn) { internal readonly string MangaConnectorIdId = mcId.Key; protected override async Task DoWorkInternal() { - if (await DbContext.MangaConnectorToManga.FirstOrDefaultAsync(c => c.Key == MangaConnectorIdId) is not { } mangaConnectorId) + Log.Debug($"Getting Chapters for MangaConnectorId {MangaConnectorIdId}..."); + // Getting MangaConnector info + if (await DbContext.MangaConnectorToManga + .Include(id => id.Obj) + .FirstOrDefaultAsync(c => c.Key == MangaConnectorIdId, CancellationToken) is not { } mangaConnectorId) + { + Log.Error("Could not get MangaConnectorId."); return []; //TODO Exception? + } if (!Tranga.TryGetMangaConnector(mangaConnectorId.MangaConnectorName, out MangaConnector? mangaConnector)) + { + Log.Error("Could not get MangaConnector."); return []; //TODO Exception? + } + Log.Debug($"Getting Chapters for MangaConnectorId {mangaConnectorId}..."); - await DbContext.Entry(mangaConnectorId).Navigation(nameof(MangaConnectorId.Obj)).LoadAsync(CancellationTokenSource.Token); Manga manga = mangaConnectorId.Obj; - await DbContext.Entry(manga).Collection(m => m.Chapters).LoadAsync(CancellationTokenSource.Token); + // Load existing Chapters (in database) + await DbContext.Entry(manga).Collection(m => m.Chapters).LoadAsync(CancellationToken); // This gets all chapters that are not downloaded - (Chapter, MangaConnectorId)[] allChapters = + (Chapter chapter, MangaConnectorId chapterId)[] allChapters = mangaConnector.GetChapters(mangaConnectorId, language).DistinctBy(c => c.Item1.Key).ToArray(); + + int beforeAmount = manga.Chapters.Count; + Log.Debug($"Got {allChapters.Length} chapters from connector."); + DbContext.Entry(manga).Collection(m => m.Chapters).CurrentValue = manga.Chapters.UnionBy(allChapters.Select(c => c.chapter), c => c.Key); + int afterAmount = manga.Chapters.Count; + + Log.Debug($"Got {afterAmount} new chapters."); - int addedChapters = 0; - foreach ((Chapter chapter, MangaConnectorId mcId) newChapter in allChapters) - { - if (Tranga.AddChapterToContext(newChapter, DbContext, out Chapter? addedChapter, CancellationTokenSource.Token) == false) - continue; - manga.Chapters.Add(addedChapter); - } - Log.Info($"{manga.Chapters.Count} existing + {addedChapters} new chapters."); - - await DbContext.Sync(CancellationTokenSource.Token); + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); return []; } diff --git a/API/Workers/MoveMangaLibraryWorker.cs b/API/Workers/MoveMangaLibraryWorker.cs index cb6f3cb..4c978f1 100644 --- a/API/Workers/MoveMangaLibraryWorker.cs +++ b/API/Workers/MoveMangaLibraryWorker.cs @@ -3,6 +3,9 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Moves a Manga to a different Library +/// public class MoveMangaLibraryWorker(Manga manga, FileLibrary toLibrary, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn) { @@ -10,20 +13,32 @@ public class MoveMangaLibraryWorker(Manga manga, FileLibrary toLibrary, IEnumera internal readonly string LibraryId = toLibrary.Key; protected override async Task DoWorkInternal() { - if (await DbContext.Mangas.FirstOrDefaultAsync(m => m.Key == MangaId, CancellationTokenSource.Token) is not { } manga) + Log.Debug("Moving Manga..."); + // Get Manga (with Chapters and Library) + if (await DbContext.Mangas + .Include(m => m.Chapters) + .Include(m => m.Library) + .FirstOrDefaultAsync(m => m.Key == MangaId, CancellationToken) is not { } manga) + { + Log.Error("Could not find Manga."); return []; //TODO Exception? - if (await DbContext.FileLibraries.FirstOrDefaultAsync(l => l.Key == LibraryId, CancellationTokenSource.Token) is not { } toLibrary) + } + // Get new Library + if (await DbContext.FileLibraries.FirstOrDefaultAsync(l => l.Key == LibraryId, CancellationToken) is not { } toLibrary) + { + Log.Error("Could not find Library."); return []; //TODO Exception? + } - await DbContext.Entry(manga).Collection(m => m.Chapters).LoadAsync(CancellationTokenSource.Token); - await DbContext.Entry(manga).Navigation(nameof(Manga.Library)).LoadAsync(CancellationTokenSource.Token); - + // Save old Path (to later move chapters) Dictionary oldPath = manga.Chapters.ToDictionary(c => c, c => c.FullArchiveFilePath); - manga.Library = toLibrary; - - if (await DbContext.Sync(CancellationTokenSource.Token) is { success: false }) + // Set new Path + DbContext.Entry(manga).Property(m => m.Library).CurrentValue = toLibrary; + + if (await DbContext.Sync(CancellationToken) is { success: false }) return []; + // Create Jobs to move chapters from old to new Path return manga.Chapters.Select(c => new MoveFileOrFolderWorker(c.FullArchiveFilePath, oldPath[c])).ToArray(); } diff --git a/API/Workers/PeriodicWorkers/CheckForNewChaptersWorker.cs b/API/Workers/PeriodicWorkers/CheckForNewChaptersWorker.cs index bbd86d3..2bd67ff 100644 --- a/API/Workers/PeriodicWorkers/CheckForNewChaptersWorker.cs +++ b/API/Workers/PeriodicWorkers/CheckForNewChaptersWorker.cs @@ -3,23 +3,28 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Creates Jobs to update available Chapters for all Manga that are marked for Download +/// public class CheckForNewChaptersWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { public DateTime LastExecution { get; set; } = DateTime.UnixEpoch; public TimeSpan Interval { get; set; } = interval??TimeSpan.FromMinutes(60); - protected override Task DoWorkInternal() + protected override async Task DoWorkInternal() { - IQueryable> connectorIdsManga = DbContext.MangaConnectorToManga + Log.Debug("Checking for new chapters..."); + List> connectorIdsManga = await DbContext.MangaConnectorToManga .Include(id => id.Obj) - .Where(id => id.UseForDownload); + .Where(id => id.UseForDownload) + .ToListAsync(CancellationToken); + Log.Debug($"Creating {connectorIdsManga.Count} update jobs..."); - List newWorkers = new(); - foreach (MangaConnectorId mangaConnectorId in connectorIdsManga) - newWorkers.Add(new RetrieveMangaChaptersFromMangaconnectorWorker(mangaConnectorId, Tranga.Settings.DownloadLanguage)); - - return new Task(() => newWorkers.ToArray()); + List newWorkers = connectorIdsManga.Select(id => new RetrieveMangaChaptersFromMangaconnectorWorker(id, Tranga.Settings.DownloadLanguage)) + .ToList(); + + return newWorkers.ToArray(); } } \ No newline at end of file diff --git a/API/Workers/PeriodicWorkers/MaintenanceWorkers/RemoveOldNotificationsWorker.cs b/API/Workers/PeriodicWorkers/MaintenanceWorkers/RemoveOldNotificationsWorker.cs index b50e579..6c659ed 100644 --- a/API/Workers/PeriodicWorkers/MaintenanceWorkers/RemoveOldNotificationsWorker.cs +++ b/API/Workers/PeriodicWorkers/MaintenanceWorkers/RemoveOldNotificationsWorker.cs @@ -1,7 +1,11 @@ using API.Schema.NotificationsContext; +using Microsoft.EntityFrameworkCore; namespace API.Workers.MaintenanceWorkers; +/// +/// Removes sent notifications from database +/// public class RemoveOldNotificationsWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { @@ -10,10 +14,14 @@ public class RemoveOldNotificationsWorker(TimeSpan? interval = null, IEnumerable protected override async Task DoWorkInternal() { - IQueryable toRemove = DbContext.Notifications.Where(n => n.IsSent || DateTime.UtcNow - n.Date > Interval); + Log.Debug("Removing old notifications..."); + List toRemove = await DbContext.Notifications.Where(n => n.IsSent).ToListAsync(CancellationToken); + Log.Debug($"Removing {toRemove.Count} old notifications..."); DbContext.RemoveRange(toRemove); - await DbContext.Sync(CancellationTokenSource.Token); + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); + return []; } diff --git a/API/Workers/PeriodicWorkers/SendNotificationsWorker.cs b/API/Workers/PeriodicWorkers/SendNotificationsWorker.cs index 0e4edd1..3b95758 100644 --- a/API/Workers/PeriodicWorkers/SendNotificationsWorker.cs +++ b/API/Workers/PeriodicWorkers/SendNotificationsWorker.cs @@ -1,8 +1,14 @@ using API.Schema.NotificationsContext; using API.Schema.NotificationsContext.NotificationConnectors; +using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Send notifications to NotificationConnectors +/// +/// +/// public class SendNotificationsWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { @@ -10,19 +16,26 @@ public class SendNotificationsWorker(TimeSpan? interval = null, IEnumerable DoWorkInternal() { - NotificationConnector[] connectors = DbContext.NotificationConnectors.ToArray(); - Notification[] notifications = DbContext.Notifications.Where(n => n.IsSent == false).ToArray(); + Log.Debug("Sending notifications..."); + List connectors = await DbContext.NotificationConnectors.ToListAsync(CancellationToken); + List unsentNotifications = await DbContext.Notifications.Where(n => n.IsSent == false).ToListAsync(CancellationToken); - foreach (Notification notification in notifications) + Log.Debug($"Sending {unsentNotifications.Count} notifications to {connectors.Count} connectors..."); + + unsentNotifications.ForEach(notification => { - foreach (NotificationConnector connector in connectors) + connectors.ForEach(connector => { connector.SendNotification(notification.Title, notification.Message); - notification.IsSent = true; - } - } + DbContext.Entry(notification).Property(n => n.IsSent).CurrentValue = true; + }); + }); - await DbContext.Sync(CancellationTokenSource.Token); + Log.Debug("Notifications sent."); + + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); + return []; } diff --git a/API/Workers/PeriodicWorkers/StartNewChapterDownloadsWorker.cs b/API/Workers/PeriodicWorkers/StartNewChapterDownloadsWorker.cs index 0e5e900..3c88781 100644 --- a/API/Workers/PeriodicWorkers/StartNewChapterDownloadsWorker.cs +++ b/API/Workers/PeriodicWorkers/StartNewChapterDownloadsWorker.cs @@ -3,22 +3,26 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Create new Workers for Chapters on Manga marked for Download, that havent been downloaded yet. +/// public class StartNewChapterDownloadsWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { public DateTime LastExecution { get; set; } = DateTime.UnixEpoch; public TimeSpan Interval { get; set; } = interval ?? TimeSpan.FromMinutes(1); - protected override Task DoWorkInternal() + protected override async Task DoWorkInternal() { - IQueryable> mangaConnectorIds = DbContext.MangaConnectorToChapter + // Get missing chapters + List> missingChapters = await DbContext.MangaConnectorToChapter .Include(id => id.Obj) - .Where(id => id.Obj.Downloaded == false && id.UseForDownload); + .Where(id => id.Obj.Downloaded == false && id.UseForDownload) + .ToListAsync(CancellationToken); - List newWorkers = new(); - foreach (MangaConnectorId mangaConnectorId in mangaConnectorIds) - newWorkers.Add(new DownloadChapterFromMangaconnectorWorker(mangaConnectorId)); + // Create new jobs + List newWorkers = missingChapters.Select(mcId => new DownloadChapterFromMangaconnectorWorker(mcId)).ToList(); - return new Task(() => newWorkers.ToArray()); + return newWorkers.ToArray(); } } \ No newline at end of file diff --git a/API/Workers/PeriodicWorkers/UpdateChaptersDownloadedWorker.cs b/API/Workers/PeriodicWorkers/UpdateChaptersDownloadedWorker.cs index e493d17..54e446a 100644 --- a/API/Workers/PeriodicWorkers/UpdateChaptersDownloadedWorker.cs +++ b/API/Workers/PeriodicWorkers/UpdateChaptersDownloadedWorker.cs @@ -3,6 +3,9 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Updates the database to reflect changes made on disk +/// public class UpdateChaptersDownloadedWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { @@ -10,10 +13,14 @@ public class UpdateChaptersDownloadedWorker(TimeSpan? interval = null, IEnumerab public TimeSpan Interval { get; set; } = interval??TimeSpan.FromMinutes(60); protected override async Task DoWorkInternal() { - foreach (Chapter dbContextChapter in DbContext.Chapters.Include(c => c.ParentManga)) - dbContextChapter.Downloaded = dbContextChapter.CheckDownloaded(); + Log.Debug("Checking chapter files..."); + List chapters = await DbContext.Chapters.Include(c => c.ParentManga).ToListAsync(CancellationToken); + Log.Debug($"Checking {chapters.Count} chapters..."); + chapters.ForEach(chapter => DbContext.Entry(chapter).Property(c => c.Downloaded).CurrentValue = chapter.CheckDownloaded()); - await DbContext.Sync(CancellationTokenSource.Token); + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); + return []; } } \ No newline at end of file diff --git a/API/Workers/PeriodicWorkers/UpdateCoversWorker.cs b/API/Workers/PeriodicWorkers/UpdateCoversWorker.cs index 5f7be48..5fed5c7 100644 --- a/API/Workers/PeriodicWorkers/UpdateCoversWorker.cs +++ b/API/Workers/PeriodicWorkers/UpdateCoversWorker.cs @@ -1,7 +1,13 @@ using API.Schema.MangaContext; +using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Creates Workers to update covers for Manga +/// +/// +/// public class UpdateCoversWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { @@ -9,11 +15,10 @@ public class UpdateCoversWorker(TimeSpan? interval = null, IEnumerable DoWorkInternal() + protected override async Task DoWorkInternal() { - List workers = new(); - foreach (MangaConnectorId mangaConnectorId in DbContext.MangaConnectorToManga) - workers.Add(new DownloadCoverFromMangaconnectorWorker(mangaConnectorId)); - return new Task(() => workers.ToArray()); + List> manga = await DbContext.MangaConnectorToManga.Where(mcId => mcId.UseForDownload).ToListAsync(CancellationToken); + List newWorkers = manga.Select(m => new DownloadCoverFromMangaconnectorWorker(m)).ToList(); + return newWorkers.ToArray(); } } \ No newline at end of file diff --git a/API/Workers/PeriodicWorkers/UpdateMetadataWorker.cs b/API/Workers/PeriodicWorkers/UpdateMetadataWorker.cs index e3aa9e0..c4a9bae 100644 --- a/API/Workers/PeriodicWorkers/UpdateMetadataWorker.cs +++ b/API/Workers/PeriodicWorkers/UpdateMetadataWorker.cs @@ -4,6 +4,11 @@ using Microsoft.EntityFrameworkCore; namespace API.Workers; +/// +/// Updates Metadata for all Manga +/// +/// +/// public class UpdateMetadataWorker(TimeSpan? interval = null, IEnumerable? dependsOn = null) : BaseWorkerWithContext(dependsOn), IPeriodic { @@ -13,18 +18,27 @@ public class UpdateMetadataWorker(TimeSpan? interval = null, IEnumerable DoWorkInternal() { - IQueryable mangaIds = DbContext.MangaConnectorToManga - .Where(m => m.UseForDownload) - .Select(m => m.ObjId); - IQueryable metadataEntriesToUpdate = DbContext.MetadataEntries - .Include(e => e.MetadataFetcher) - .Where(e => - mangaIds.Any(id => id == e.MangaId)); - - foreach (MetadataEntry metadataEntry in metadataEntriesToUpdate) - await metadataEntry.MetadataFetcher.UpdateMetadata(metadataEntry, DbContext, CancellationTokenSource.Token); + Log.Debug("Updating metadata..."); + // Get MetadataEntries of Manga marked for download + List metadataEntriesToUpdate = await DbContext.MangaConnectorToManga + .Where(m => m.UseForDownload) // Get marked Manga + .Join( + DbContext.MetadataEntries.Include(e => e.MetadataFetcher).Include(e => e.Manga), + mcId => mcId.ObjId, + e => e.MangaId, + (mcId, e) => e) // return MetadataEntry + .ToListAsync(CancellationToken); + Log.Debug($"Updating metadata of {metadataEntriesToUpdate.Count} manga..."); - await DbContext.Sync(CancellationTokenSource.Token); + foreach (MetadataEntry metadataEntry in metadataEntriesToUpdate) + { + Log.Debug($"Updating metadata of {metadataEntry}..."); + await metadataEntry.MetadataFetcher.UpdateMetadata(metadataEntry, DbContext, CancellationToken); + } + Log.Debug("Updated metadata."); + + if(await DbContext.Sync(CancellationToken) is { success: false } e) + Log.Error($"Failed to save database changes: {e.exceptionMessage}"); return []; }