Chapter as Comparable

Tranga/Chapter.cs

@@ -7,7 +7,7 @@ namespace Tranga;
 /// Has to be Part of a publication
 /// Includes the Chapter-Name, -VolumeNumber, -ChapterNumber, the location of the chapter on the internet and the saveName of the local file.
 /// </summary>
-public readonly struct Chapter
+public readonly struct Chapter : IComparable
 {
     // ReSharper disable once MemberCanBePrivate.Global
     public Manga parentManga { get; }
@@ -41,6 +41,33 @@ public readonly struct Chapter
         return $"Chapter {parentManga.sortName} {parentManga.internalId} {chapterNumber} {name}";
     }
 
+    public int CompareTo(object? obj)
+    {
+        if (obj is Chapter otherChapter)
+        {
+            if (float.TryParse(volumeNumber, GlobalBase.numberFormatDecimalPoint, out float volumeNumberFloat) &&
+                float.TryParse(chapterNumber, GlobalBase.numberFormatDecimalPoint, out float chapterNumberFloat) &&
+                float.TryParse(otherChapter.volumeNumber, GlobalBase.numberFormatDecimalPoint,
+                    out float otherVolumeNumberFloat) &&
+                float.TryParse(otherChapter.chapterNumber, GlobalBase.numberFormatDecimalPoint,
+                    out float otherChapterNumberFloat))
+            {
+
+                switch (volumeNumberFloat.CompareTo(otherVolumeNumberFloat))
+                {
+                    case < 0:
+                        return -1;
+                    case > 0:
+                        return 1;
+                    default:
+                        return chapterNumberFloat.CompareTo(otherChapterNumberFloat);
+                }
+            }
+            else throw new FormatException($"Value could not be parsed");
+        }
+        throw new ArgumentException($"{obj} can not be compared to {this}");
+    }
+
     /// <summary>
     /// Checks if a chapter-archive is already present
     /// </summary>

Tranga/MangaConnectors/Bato.cs

@@ -136,7 +136,7 @@ public class Bato : MangaConnector
 		//Return Chapters ordered by Chapter-Number
 		List<Chapter> chapters = ParseChaptersFromHtml(manga, requestUrl);
 		Log($"Got {chapters.Count} chapters. {manga}");
-		return chapters.OrderBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint)).ToArray();
+		return chapters.Order().ToArray();
 	}
 
 	private List<Chapter> ParseChaptersFromHtml(Manga manga, string mangaUrl)

Tranga/MangaConnectors/MangaConnector.cs

@@ -70,7 +70,7 @@ public abstract class MangaConnector : GlobalBase
         try
         {
             Chapter latestChapterAvailable =
-                allChapters.MaxBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint));
+                allChapters.Max();
             manga.latestChapterAvailable =
                 Convert.ToSingle(latestChapterAvailable.chapterNumber, numberFormatDecimalPoint);
         }

Tranga/MangaConnectors/MangaDex.cs

@@ -253,7 +253,7 @@ public class MangaDex : MangaConnector
 
         //Return Chapters ordered by Chapter-Number
         Log($"Got {chapters.Count} chapters. {manga}");
-        return chapters.OrderBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint)).ToArray();
+        return chapters.Order().ToArray();
     }
 
     public override HttpStatusCode DownloadChapter(Chapter chapter, ProgressToken? progressToken = null)

Tranga/MangaConnectors/MangaKatana.cs

@@ -165,7 +165,7 @@ public class MangaKatana : MangaConnector
 		//Return Chapters ordered by Chapter-Number
 		List<Chapter> chapters = ParseChaptersFromHtml(manga, requestUrl);
 		Log($"Got {chapters.Count} chapters. {manga}");
-		return chapters.OrderBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint)).ToArray();
+		return chapters.Order().ToArray();
 	}
 
 	private List<Chapter> ParseChaptersFromHtml(Manga manga, string mangaUrl)

Tranga/MangaConnectors/MangaLife.cs

@@ -159,7 +159,7 @@ public class MangaLife : MangaConnector
         }
         //Return Chapters ordered by Chapter-Number
         Log($"Got {chapters.Count} chapters. {manga}");
-        return chapters.OrderBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint)).ToArray();
+        return chapters.Order().ToArray();
     }
 
     public override HttpStatusCode DownloadChapter(Chapter chapter, ProgressToken? progressToken = null)

Tranga/MangaConnectors/Manganato.cs

@@ -152,12 +152,7 @@ public class Manganato : MangaConnector
             return Array.Empty<Chapter>();
         List<Chapter> chapters = ParseChaptersFromHtml(manga, requestResult.htmlDocument);
         Log($"Got {chapters.Count} chapters. {manga}");
-        return chapters.OrderBy(chapter =>
+        return chapters.Order().ToArray();
-        {
-            if (float.TryParse(chapter.chapterNumber, numberFormatDecimalPoint, out float chapterNumber))
-                return chapterNumber;
-            else return 0;
-        }).ToArray();
     }
 
     private List<Chapter> ParseChaptersFromHtml(Manga manga, HtmlDocument document)

Tranga/MangaConnectors/Mangasee.cs

@@ -206,7 +206,7 @@ public class Mangasee : MangaConnector
 
             //Return Chapters ordered by Chapter-Number
             Log($"Got {chapters.Count} chapters. {manga}");
-            return chapters.OrderBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint)).ToArray();
+            return chapters.Order().ToArray();
         }
         catch (HttpRequestException e)
         {

Tranga/MangaConnectors/Mangaworld.cs

@@ -141,7 +141,7 @@ public class Mangaworld: MangaConnector
             return Array.Empty<Chapter>();
         List<Chapter> chapters = ParseChaptersFromHtml(manga, requestResult.htmlDocument);
         Log($"Got {chapters.Count} chapters. {manga}");
-        return chapters.OrderBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint)).ToArray();
+        return chapters.Order().ToArray();
     }
 
     private List<Chapter> ParseChaptersFromHtml(Manga manga, HtmlDocument document)