#85 included characters with accents, umlauts, and +

Fix #87, manga that return no chapters, crash when updating latest released chapter.

Tranga/Jobs/UpdateMetadata.cs

@@ -23,10 +23,11 @@ public class UpdateMetadata : Job
 
     protected override IEnumerable<Job> ExecuteReturnSubTasksInternal(JobBoss jobBoss)
     {
+        //Retrieve new Metadata
         Manga? possibleUpdatedManga = mangaConnector.GetMangaFromId(manga.publicationId);
         if (possibleUpdatedManga is { } updatedManga)
         {
-            if(updatedManga.Equals(this.manga))
+            if(updatedManga.Equals(this.manga))//Check if anything changed
                 return Array.Empty<Job>();
             
             this.manga.UpdateMetadata(updatedManga);

Tranga/Manga.cs

@@ -44,7 +44,7 @@ public struct Manga
     public float latestChapterDownloaded { get; set; }
     public float latestChapterAvailable { get; set; }
 
-    private static readonly Regex LegalCharacters = new (@"[A-Z]*[a-z]*[0-9]* *\.*-*,*'*\'*\)*\(*~*!*");
+    private static readonly Regex LegalCharacters = new (@"[A-Za-zÀ-ÖØ-öø-ÿ0-9 \.\-,'\'\)\(~!\+]*");
 
     [JsonConstructor]
     public Manga(string sortName, List<string> authors, string? description, Dictionary<string,string> altTitles, string[] tags, string? coverUrl, string? coverFileNameInCache, Dictionary<string,string>? links, int? year, string? originalLanguage, string status, string publicationId, ReleaseStatusByte releaseStatus = 0, string? websiteUrl = null, string? folderName = null, float? ignoreChaptersBelow = 0)
@@ -77,7 +77,7 @@ public struct Manga
         this.sortName = newManga.sortName;
         this.description = newManga.description;
         foreach (string author in newManga.authors)
-            if(this.authors.Contains(author))
+            if(!this.authors.Contains(author))
                 this.authors.Add(author);
         this.status = newManga.status;
         this.year = newManga.year;
@@ -93,7 +93,7 @@ public struct Manga
                this.releaseStatus == compareManga.releaseStatus &&
                this.sortName == compareManga.sortName &&
                this.latestChapterAvailable.Equals(compareManga.latestChapterAvailable) &&
-               this.tags.Equals(compareManga.tags);
+               this.tags.SequenceEqual(compareManga.tags);
     }
 
     public override string ToString()

Tranga/MangaConnectors/MangaConnector.cs

@@ -59,14 +59,26 @@ public abstract class MangaConnector : GlobalBase
     {
         Log($"Getting new Chapters for {manga}");
         Chapter[] allChapters = this.GetChapters(manga, language);
+        if (allChapters.Length < 1)
+            return Array.Empty<Chapter>();
+        
         Log($"Checking for duplicates {manga}");
         List<Chapter> newChaptersList = allChapters.Where(nChapter => float.TryParse(nChapter.chapterNumber, numberFormatDecimalPoint, out float chapterNumber)
                                                                       && chapterNumber > manga.ignoreChaptersBelow
                                                                       && !nChapter.CheckChapterIsDownloaded(settings.downloadLocation)).ToList();
         Log($"{newChaptersList.Count} new chapters. {manga}");
+        try
+        {
             Chapter latestChapterAvailable =
                 allChapters.MaxBy(chapter => Convert.ToSingle(chapter.chapterNumber, numberFormatDecimalPoint));
-        manga.latestChapterAvailable = Convert.ToSingle(latestChapterAvailable.chapterNumber, numberFormatDecimalPoint);
+            manga.latestChapterAvailable =
+                Convert.ToSingle(latestChapterAvailable.chapterNumber, numberFormatDecimalPoint);
+        }
+        catch (Exception e)
+        {
+            Log(e.ToString());
+            Log($"Failed getting new Chapters for {manga}");
+        }
         
         return newChaptersList.ToArray();
     }