Compare commits

...

2 Commits

Author SHA1 Message Date
31a0c6ffb2 Fix build warnings 2023-10-04 18:14:46 +02:00
668a3b3a96 MangaDex nullchecking in response 2023-10-04 18:14:12 +02:00
4 changed files with 35 additions and 14 deletions

View File

@ -62,7 +62,7 @@ public class MemoryLogger : LoggerBase
ret.Add(_logMessages.GetValueAtIndex(_lastLogMessageIndex + retIndex).ToString()); ret.Add(_logMessages.GetValueAtIndex(_lastLogMessageIndex + retIndex).ToString());
} }
} }
catch (NullReferenceException e)//Called when LogMessage has not finished writing catch (NullReferenceException)//Called when LogMessage has not finished writing
{ {
break; break;
} }

View File

@ -225,7 +225,7 @@ public abstract class MangaConnector : GlobalBase
} }
if (progressToken?.cancellationRequested ?? false) if (progressToken?.cancellationRequested ?? false)
{ {
progressToken?.Complete(); progressToken.Complete();
return HttpStatusCode.RequestTimeout; return HttpStatusCode.RequestTimeout;
} }
progressToken?.Increment(); progressToken?.Increment();

View File

@ -51,16 +51,23 @@ public class MangaDex : MangaConnector
if (result is null) if (result is null)
break; break;
if(result.ContainsKey("total"))
total = result["total"]!.GetValue<int>(); //Update the total number of Publications total = result["total"]!.GetValue<int>(); //Update the total number of Publications
else continue;
if (result.ContainsKey("data"))
{
JsonArray mangaInResult = result["data"]!.AsArray(); //Manga-data-Array JsonArray mangaInResult = result["data"]!.AsArray(); //Manga-data-Array
//Loop each Manga and extract information from JSON //Loop each Manga and extract information from JSON
foreach (JsonNode? mangaNode in mangaInResult) foreach (JsonNode? mangaNode in mangaInResult)
{ {
if(mangaNode is null)
continue;
Log($"Getting publication data. {++loadedPublicationData}/{total}"); Log($"Getting publication data. {++loadedPublicationData}/{total}");
Manga manga = MangaFromJsonObject((JsonObject)mangaNode); if(MangaFromJsonObject((JsonObject) mangaNode) is { } manga)
retManga.Add(manga); //Add Publication (Manga) to result retManga.Add(manga); //Add Publication (Manga) to result
} }
}else continue;
} }
Log($"Retrieved {retManga.Count} publications. Term=\"{publicationTitle}\""); Log($"Retrieved {retManga.Count} publications. Term=\"{publicationTitle}\"");
return retManga.ToArray(); return retManga.ToArray();
@ -81,20 +88,30 @@ public class MangaDex : MangaConnector
return null; return null;
} }
private Manga MangaFromJsonObject(JsonObject manga) private Manga? MangaFromJsonObject(JsonObject manga)
{ {
if (!manga.ContainsKey("attributes"))
return null;
JsonObject attributes = manga["attributes"]!.AsObject(); JsonObject attributes = manga["attributes"]!.AsObject();
if(!manga.ContainsKey("id"))
return null;
string publicationId = manga["id"]!.GetValue<string>(); string publicationId = manga["id"]!.GetValue<string>();
if(!attributes.ContainsKey("title"))
return null;
string title = attributes["title"]!.AsObject().ContainsKey("en") && attributes["title"]!["en"] is not null string title = attributes["title"]!.AsObject().ContainsKey("en") && attributes["title"]!["en"] is not null
? attributes["title"]!["en"]!.GetValue<string>() ? attributes["title"]!["en"]!.GetValue<string>()
: attributes["title"]![((IDictionary<string, JsonNode?>)attributes["title"]!.AsObject()).Keys.First()]!.GetValue<string>(); : attributes["title"]![((IDictionary<string, JsonNode?>)attributes["title"]!.AsObject()).Keys.First()]!.GetValue<string>();
if(!attributes.ContainsKey("description"))
return null;
string? description = attributes["description"]!.AsObject().ContainsKey("en") && attributes["description"]!["en"] is not null string? description = attributes["description"]!.AsObject().ContainsKey("en") && attributes["description"]!["en"] is not null
? attributes["description"]!["en"]!.GetValue<string?>() ? attributes["description"]!["en"]!.GetValue<string?>()
: null; : null;
if(!attributes.ContainsKey("altTitles"))
return null;
JsonArray altTitlesObject = attributes["altTitles"]!.AsArray(); JsonArray altTitlesObject = attributes["altTitles"]!.AsArray();
Dictionary<string, string> altTitlesDict = new(); Dictionary<string, string> altTitlesDict = new();
foreach (JsonNode? altTitleNode in altTitlesObject) foreach (JsonNode? altTitleNode in altTitlesObject)
@ -104,6 +121,8 @@ public class MangaDex : MangaConnector
altTitlesDict.TryAdd(key, altTitleObject[key]!.GetValue<string>()); altTitlesDict.TryAdd(key, altTitleObject[key]!.GetValue<string>());
} }
if(!attributes.ContainsKey("tags"))
return null;
JsonArray tagsObject = attributes["tags"]!.AsArray(); JsonArray tagsObject = attributes["tags"]!.AsArray();
HashSet<string> tags = new(); HashSet<string> tags = new();
foreach (JsonNode? tagNode in tagsObject) foreach (JsonNode? tagNode in tagsObject)
@ -149,6 +168,8 @@ public class MangaDex : MangaConnector
? attributes["originalLanguage"]!.GetValue<string?>() ? attributes["originalLanguage"]!.GetValue<string?>()
: null; : null;
if(!attributes.ContainsKey("status"))
return null;
string status = attributes["status"]!.GetValue<string>(); string status = attributes["status"]!.GetValue<string>();
Manga pub = new( Manga pub = new(

View File

@ -52,7 +52,7 @@ public class Server : GlobalBase
}); });
t.Start(); t.Start();
} }
catch (HttpListenerException e) catch (HttpListenerException)
{ {
} }