API/Schema/Chapter.cs

@@ -172,18 +172,13 @@ public class Chapter : IComparable<Chapter>
     internal string GetComicInfoXmlString()
     {
         XElement comicInfo = new("ComicInfo",
+            new XElement("Tags", string.Join(',', ParentManga.MangaTags.Select(tag => tag.Tag))),
+            new XElement("LanguageISO", ParentManga.OriginalLanguage),
+            new XElement("Title", Title),
+            new XElement("Writer", string.Join(',', ParentManga.Authors.Select(author => author.AuthorName))),
+            new XElement("Volume", VolumeNumber),
             new XElement("Number", ChapterNumber)
         );
-        if(Title is not null)
-            comicInfo.Add(new XElement("Title", Title));
-        if(ParentManga.MangaTags.Count > 0)
-            comicInfo.Add(new XElement("Tags", string.Join(',', ParentManga.MangaTags.Select(tag => tag.Tag))));
-        if(VolumeNumber is not null)
-            comicInfo.Add(new XElement("Volume", VolumeNumber));
-        if(ParentManga.Authors.Count > 0)
-            comicInfo.Add(new XElement("Writer", string.Join(',', ParentManga.Authors.Select(author => author.AuthorName))));
-        if(ParentManga.OriginalLanguage is not null)
-            comicInfo.Add(new XElement("LanguageISO", ParentManga.OriginalLanguage));
         return comicInfo.ToString();
     }
 

API/Schema/Jobs/DownloadSingleChapterJob.cs

@@ -51,18 +51,10 @@ public class DownloadSingleChapterJob : Job
             Log.Info($"No imageUrls for chapter {ChapterId}");
             return [];
         }
-        context.Entry(Chapter.ParentManga).Reference<LocalLibrary>(m => m.Library).Load(); //Need to explicitly load, because we are not accessing navigation directly...
         string saveArchiveFilePath = Chapter.FullArchiveFilePath;
-        Log.Debug($"Chapter path: {saveArchiveFilePath}");
         
         //Check if Publication Directory already exists
-        string? directoryPath = Path.GetDirectoryName(saveArchiveFilePath);
-        if (directoryPath is null)
-        {
-            Log.Error($"Directory path could not be found: {saveArchiveFilePath}");
-            this.state = JobState.Failed;
-            return [];
-        }
+        string directoryPath = Path.GetDirectoryName(saveArchiveFilePath)!;
         if (!Directory.Exists(directoryPath))
         {
             Log.Info($"Creating publication Directory: {directoryPath}");

API/Schema/Jobs/RetrieveChaptersJob.cs

@@ -41,7 +41,7 @@ public class RetrieveChaptersJob : Job
     protected override IEnumerable<Job> RunInternal(PgsqlContext context)
     {
         // This gets all chapters that are not downloaded
-        Chapter[] allChapters = Manga.MangaConnector.GetChapters(Manga, Language).DistinctBy(c => c.ChapterId).ToArray();
+        Chapter[] allChapters = Manga.MangaConnector.GetChapters(Manga, Language);
         Chapter[] newChapters = allChapters.Where(chapter => Manga.Chapters.Contains(chapter) == false).ToArray();
         Log.Info($"{newChapters.Length} new chapters.");
 

API/Schema/MangaConnectors/MangaDex.cs

@@ -228,8 +228,8 @@ public class MangaDex : MangaConnector
         string? id = jToken.Value<string>("id");
         
         JObject? attributes = jToken["attributes"] as JObject;
-        string? name = attributes?["title"]?.Value<string>("en") ?? attributes?["title"]?.First?.First?.Value<string>();
-        string? description = attributes?["description"]?.Value<string>("en")??attributes?["description"]?.First?.First?.Value<string>();
+        string? name = attributes?["title"]?.Value<string>("en");
+        string? description = attributes?["description"]?.Value<string>("en");
         string? status = attributes?["status"]?.Value<string>();
         uint? year = attributes?["year"]?.Value<uint>();
         string? originalLanguage = attributes?["originalLanguage"]?.Value<string>();
@@ -288,7 +288,7 @@ public class MangaDex : MangaConnector
         
         List<MangaTag> tags = tagsJArray
             .Where(t => t.Value<string>("type") == "tag")
-            .Select(t => t["attributes"]?["name"]?.Value<string>("en")??t["attributes"]?["name"]?.First?.First?.Value<string>())
+            .Select(t => t["attributes"]?["name"]?.Value<string>("en"))
             .Select(str => str is not null ? new MangaTag(str) : null)
             .Where(x => x is not null).ToList()!;