Tranga-CLI/Tranga_Cli.cs

@@ -105,7 +105,7 @@ public static class Tranga_Cli
         int tIndex = 0;
         Console.WriteLine("Tasks:");
         foreach(TrangaTask trangaTask in tasks)
-            Console.WriteLine($"{tIndex++}: {trangaTask.task} - {trangaTask.reoccurrence} - {trangaTask.publication?.sortName} - {trangaTask.connectorName} - {trangaTask.lastExecuted}");
+            Console.WriteLine($"{tIndex++}: {trangaTask.task} - {trangaTask.reoccurrence} - {trangaTask.publication?.sortName} - {trangaTask.connectorName}");
         return tasks.Length;
     }
 
@@ -114,7 +114,7 @@ public static class Tranga_Cli
         int length = PrintTasks(taskManager);
         
         TrangaTask[] tasks = taskManager.GetAllTasks();
-        Console.WriteLine($"Select Task (0-{length}):");
+        Console.WriteLine($"Select Task (0-{length - 1}):");
 
         string? selectedTask = Console.ReadLine();
         while(selectedTask is null || selectedTask.Length < 1)

Tranga/Connector.cs

@@ -20,15 +20,6 @@ public abstract class Connector
 
     protected void DownloadChapter(string[] imageUrls, string saveArchiveFilePath)
     {
-        string[] splitPath = saveArchiveFilePath.Split(Path.DirectorySeparatorChar);
-        string directoryPath = Path.Combine(splitPath.Take(splitPath.Length - 1).ToArray());
-        if (!Directory.Exists(directoryPath))
-            Directory.CreateDirectory(directoryPath);
-        
-        string fullPath = $"{saveArchiveFilePath}.cbz";
-        if (File.Exists(fullPath))
-            return;
-        
         string tempFolder = Path.GetTempFileName();
         File.Delete(tempFolder);
         Directory.CreateDirectory(tempFolder);
@@ -40,7 +31,14 @@ public abstract class Connector
             string extension = split[split.Length - 1];
             DownloadImage(imageUrl, Path.Join(tempFolder, $"{chapter++}.{extension}"));
         }
-        
+
+        string[] splitPath = saveArchiveFilePath.Split(Path.DirectorySeparatorChar);
+        string directoryPath = Path.Combine(splitPath.Take(splitPath.Length - 1).ToArray());
+        if (!Directory.Exists(directoryPath))
+            Directory.CreateDirectory(directoryPath);
+
+        string fullPath = $"{saveArchiveFilePath}.cbz";
+        File.Delete(fullPath);
         ZipFile.CreateFromDirectory(tempFolder, fullPath);
     }
 

Tranga/Connectors/MangaDex.cs

@@ -1,5 +1,4 @@
 using System.Globalization;
-using System.Net;
 using System.Text.Json;
 using System.Text.Json.Nodes;
 
@@ -22,11 +21,7 @@ public class MangaDex : Connector
         HashSet<Publication> publications = new();
         while (offset < total)
         {
-            DownloadClient.RequestResult requestResult =
+            DownloadClient.RequestResult requestResult = _downloadClient.MakeRequest($"https://api.mangadex.org/manga?limit={limit}&title={publicationTitle}&offset={offset}");
-                _downloadClient.MakeRequest(
-                    $"https://api.mangadex.org/manga?limit={limit}&title={publicationTitle}&offset={offset}");
-            if (requestResult.statusCode != HttpStatusCode.OK)
-                break;
             JsonObject? result = JsonSerializer.Deserialize<JsonObject>(requestResult.result);
             offset += limit;
             if (result is null)
@@ -126,10 +121,7 @@ public class MangaDex : Connector
         while (offset < total)
         {
             DownloadClient.RequestResult requestResult =
-                _downloadClient.MakeRequest(
+                _downloadClient.MakeRequest($"https://api.mangadex.org/manga/{id}/feed?limit={limit}&offset={offset}&translatedLanguage%5B%5D={language}");
-                    $"https://api.mangadex.org/manga/{id}/feed?limit={limit}&offset={offset}&translatedLanguage%5B%5D={language}");
-            if (requestResult.statusCode != HttpStatusCode.OK)
-                break;
             JsonObject? result = JsonSerializer.Deserialize<JsonObject>(requestResult.result);
             
             offset += limit;
@@ -171,8 +163,6 @@ public class MangaDex : Connector
     {
         DownloadClient.RequestResult requestResult =
             _downloadClient.MakeRequest($"https://api.mangadex.org/at-home/server/{chapter.url}?forcePort443=false'");
-        if (requestResult.statusCode != HttpStatusCode.OK)
-            return;
         JsonObject? result = JsonSerializer.Deserialize<JsonObject>(requestResult.result);
         if (result is null)
             return;
@@ -198,16 +188,12 @@ public class MangaDex : Connector
     public override void DownloadCover(Publication publication)
     {
         string publicationPath = Path.Join(downloadLocation, publication.folderName);
-        Directory.CreateDirectory(publicationPath);
+        DirectoryInfo dirInfo = new DirectoryInfo(publicationPath);
-        DirectoryInfo dirInfo = new (publicationPath);
         foreach(FileInfo fileInfo in dirInfo.EnumerateFiles())
             if (fileInfo.Name.Contains("cover."))
                 return;
-
+        
-        DownloadClient.RequestResult requestResult =
+        DownloadClient.RequestResult requestResult = _downloadClient.MakeRequest($"https://api.mangadex.org/cover/{publication.posterUrl}");
-            _downloadClient.MakeRequest($"https://api.mangadex.org/cover/{publication.posterUrl}");
-        if (requestResult.statusCode != HttpStatusCode.OK)
-            return;
         JsonObject? result = JsonSerializer.Deserialize<JsonObject>(requestResult.result);
         if (result is null)
             return;

Tranga/TaskManager.cs

@@ -44,8 +44,6 @@ public class TaskManager
         if (!_allTasks.Any(trangaTask => trangaTask.task != task && trangaTask.connectorName != connector.name &&
                                          trangaTask.publication?.downloadUrl != publication?.downloadUrl))
         {
-            if(task != TrangaTask.Task.UpdatePublications)
-                _chapterCollection.Add((Publication)publication!, new List<Chapter>());
             _allTasks.Add(new TrangaTask(connector.name, task, publication, reoccurrence, language));
             ExportTasks(Directory.GetCurrentDirectory());
         }